Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [DO NOT REPLY] to the name for the accounts email. #4521

Open
1 task
cielf opened this issue Jul 14, 2024 · 14 comments · May be fixed by #4803
Open
1 task

Add [DO NOT REPLY] to the name for the accounts email. #4521

cielf opened this issue Jul 14, 2024 · 14 comments · May be fixed by #4803
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 14, 2024

Summary

Add [DO NOT REPLY] to the name for the accounts email

Why?

Just another prompt so that fewer partners will send us queries that should go to their bank

Details

[email protected]

Criteria for completion

  • The account email name has [DO NOT REPLY] appended to it
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 14, 2024
@Trevor-Robinson
Copy link
Contributor

I would like to take this issue.

@cielf
Copy link
Collaborator Author

cielf commented Jul 19, 2024

It is yours.

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Jul 19, 2024
@Trevor-Robinson
Copy link
Contributor

I was taking a look at this issue today and had a question:

Most mailers have a default from that is set to "Please do not reply to this email as this mail box is not monitored — Human Essentials [email protected]". The mailers that show up from [email protected] are the only ones that don't have this default from set. Should the default from in those mailers just be set to match or should it specifically be set to "[DO NOT REPLY][email protected]"?

Or am I going about this wrong and the goal is to change the actual accounts address at the Devise configuration level, instead of just overriding the from field when the emails go out?

@cielf
Copy link
Collaborator Author

cielf commented Jul 22, 2024

@dorner - Can you address the above question, please? Thank you!

@dorner
Copy link
Collaborator

dorner commented Jul 26, 2024

We definitely don't need to override the actual account. Just the from. And yes, ideally it should match everywhere.

@cielf up to you if you prefer the DO NOT REPLY prefix or the longer one. I like the first one, myself :)

@cielf
Copy link
Collaborator Author

cielf commented Jul 27, 2024

DO NOT REPLY seems fine. The longer one would be a lie for [email protected].

@awwaiid awwaiid modified the milestone: Tasks 2024 Jul 28, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Aug 28, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Automatically unassigned after 7 days of inactivity.

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Sep 4, 2024
@Trevor-Robinson
Copy link
Contributor

Would it be possible for me to pick this back up? I was away for a bit.

@cielf
Copy link
Collaborator Author

cielf commented Sep 19, 2024

Sure!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Sep 19, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Oct 28, 2024
@Sukhpreet-s
Copy link

Hi @cielf , I’d like to work on this! I have linked a WIP draft PR with some code changes and description while I was looking into this issue.

If possible, could someone please review the PR to ensure I’m heading in the right direction?

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Nov 26, 2024
@cielf
Copy link
Collaborator Author

cielf commented Nov 26, 2024

It looks to me as if you are headed in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants