Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] On new item, category dropdown disappears after error #4674

Open
2 tasks
cielf opened this issue Sep 29, 2024 · 6 comments
Open
2 tasks

[BUG] On new item, category dropdown disappears after error #4674

cielf opened this issue Sep 29, 2024 · 6 comments
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 29, 2024

Summary

If you have an error on new item, the category list for selection disappears. It shouldn't.

Details

Recreation

login as [email protected]
Select Inventory, then Items & Inventory, then Items, then New Item
Click in the "Category" field. You will see a list of categories to choose from
Click Save
Click in the "Category" field. You no longer see a list of categories to choose from.

Hint

It's probably re-rendering without resetting up the category stuff.

Required change

The ability to select "Category" should still be available after having an error on this screen.

Criteria for completion

  • Behaviour as described above
  • tests to confirm the behaviour.

Noted by Gabe Torres, June 4 2024
"Thanks for posting, Daniela. It reminded me of something I noticed that also concerns forms. I thought it could have been my branch, but I tried it on main, and the issue persisted.
Recreating:
When logged in as a bank, navigate to http://localhost:3000/items/new
Submit a blank form.
Bug: The drop-down menu for category no longer functions and changes into some kind of numeric input that can be decreased or increased.
I’m not sure if this is a known issue or not, but I thought I’d share."

@bdeanhardt
Copy link

I tackled this one! Here's my PR #4703

@princekumarg12
Copy link
Contributor

Hi! @cielf I'm new to this project, and I would love to work on this issue. Looking forward to contributing!

@cielf
Copy link
Collaborator Author

cielf commented Oct 9, 2024

@princekumarg12 There was already a PR in progress for this one, so I think we'll go with that one, if it works.

Copy link
Contributor

github-actions bot commented Nov 9, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented Nov 16, 2024

This is in the latter cycles of the pull request review and fix.

@github-actions github-actions bot removed the stale label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants