Allow supervisors to see *all* volunteers (including those without learning hours) #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new scope to SupervisorVolunteer so that we can return the learning hours of *all* volunteers (including those without hours entered) Also added the supervisor_volunteer variable to the templates so that we use it instead of @learning_hour
lenikadali
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
lenikadali
changed the title
compwron
reviewed
Oct 8, 2024
|
so this is where@learning_hours comes from. And is used here: casa/app/policies/learning_hour_policy.rb Line 32 in 11d3e28 That means that you would want to have the newly changed learning hours scope on the casa/app/models/learning_hour.rb Line 19 in 01b966b Also just to clarify (maybe you can tell me this doesnt work) but this will return LearningHours opposed to Supervisor or Volunteers but as long as it provides a display_name, total_time_spent, user_id, etc it works |
Reverted the changes made to the SupervisorVolunteer model and switched to use LearningHour as originally intended
|
@elasticspoon so I've updated the PR to use the Steps to reproduce:
|
|
Closing this since it hasn't moved for a while now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5979
What changed, and why?
We need to add a new query that shows all volunteers. The current implementation only shows volunteers with hours entered, and not volunteers who've been added but do not have learning hours entered.
How is this tested? (please write tests!) 💖💪
This is a work in progress but should we settle on the implementation, there should be tests in
spec/models/supervisor_volunteer.rbfor the newly added scope.Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system
Screenshots please :)
None yet.
Feelings gif (optional)