-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request specs fail after upgrading to Rack 3 #2814
Comments
👋 We don't include any behaviour for this ourselves and rely on the upstream Rails / rack-test helpers, is Rack 3 supported by Rails 8? I think 7 is still pinned to 2.x isn't it? |
No, Rails 7 is not pinned to 2.x. At least 7.1 is not which is what we are using. I see what happened on our end. We have another gem using/requiring Sinatra and at least Sinatra 4.1.1 is requiring rack >= 3.0.0. So, that is what caused our jump. I will see if we want to continue as things are or downgrade Sinatra to something not requiring rack 3. |
My mistake 7.0 is, but not anything later, what version of Rack are you on? It seems like 3.1 made "rack.input" fully optional? |
Bundle installed rack 3.1.8. In spite of "rack.input" being optional in this version, it still gave me the error message without me adding it into the test. |
We have a number of request specs for our API and after upgrading Rack from 2.x to 3.x, they all started failing with:
The way to resolve these errors is to convert the get request to
However, it seems very verbose to add this to each request. Am I missing an easier / better way to avoid this error?
This is on rspec-rails 7.1.0 and rspec-core 3.13.2.
The text was updated successfully, but these errors were encountered: