4.19.1: bug in %___build_pre_env definition

[kloczek]

rpm/macros.in

Lines 762 to 766 in b2e8a2b

	%___build_pre_env \
	RPM_SOURCE_DIR=\"%{_sourcedir}\"\
	RPM_BUILD_DIR=\"%{_builddir}\"\
	RPM_OPT_FLAGS=\"%{optflags}\"\
	RPM_LD_FLAGS=\"%{?build_ldflags}\"\

Issue is that %{?build_ldflags} it is no value of the macro but it provides information is macro defined or not.

When I've added in my cyrus-sasl.spec file "%global build_ldflags %{?build_ldflags} -Wl,--enable-new-dtags` rpmbuild failed with

error: /home/tkloczko/rpmbuild/SPECS/build/cyrus-sasl.spec: line 209: Too many levels of recursion in macro expansion. It is likely caused by recursive macro declaration.
 63<                                                                                                                                (%build_ldflags)
 62<                                                                                                                              (%build_ldflags)
 61<                                                                                                                            (%build_ldflags)
 60<                                                                                                                          (%build_ldflags)
 59<                                                                                                                        (%build_ldflags)
 58<                                                                                                                      (%build_ldflags)
 57<                                                                                                                    (%build_ldflags)
 56<                                                                                                                  (%build_ldflags)
 55<                                                                                                                (%build_ldflags)
 54<                                                                                                              (%build_ldflags)
 53<                                                                                                            (%build_ldflags)
 52<                                                                                                          (%build_ldflags)
 51<                                                                                                        (%build_ldflags)
 50<                                                                                                      (%build_ldflags)
 49<                                                                                                    (%build_ldflags)
 48<                                                                                                  (%build_ldflags)
 47<                                                                                                (%build_ldflags)
 46<                                                                                              (%build_ldflags)
 45<                                                                                            (%build_ldflags)
 44<                                                                                          (%build_ldflags)
 43<                                                                                        (%build_ldflags)
 42<                                                                                      (%build_ldflags)
 41<                                                                                    (%build_ldflags)
 40<                                                                                  (%build_ldflags)
 39<                                                                                (%build_ldflags)
 38<                                                                              (%build_ldflags)
 37<                                                                            (%build_ldflags)
 36<                                                                          (%build_ldflags)
 35<                                                                        (%build_ldflags)
 34<                                                                      (%build_ldflags)
 33<                                                                    (%build_ldflags)
 32<                                                                  (%build_ldflags)
 31<                                                                (%build_ldflags)
 30<                                                              (%build_ldflags)
 29<                                                            (%build_ldflags)
 28<                                                          (%build_ldflags)
 27<                                                        (%build_ldflags)
 26<                                                      (%build_ldflags)
 25<                                                    (%build_ldflags)
 24<                                                  (%build_ldflags)
 23<                                                (%build_ldflags)
 22<                                              (%build_ldflags)
 21<                                            (%build_ldflags)
 20<                                          (%build_ldflags)
 19<                                        (%build_ldflags)
 18<                                      (%build_ldflags)
 17<                                    (%build_ldflags)
 16<                                  (%build_ldflags)
 15<                                (%build_ldflags)
 14<                              (%build_ldflags)
 13<                            (%build_ldflags)
 12<                          (%build_ldflags)
 11<                        (%build_ldflags)
 10<                      (%build_ldflags)
  9<                    (%build_ldflags)
  8<                  (%build_ldflags)
  7<                (%build_ldflags)
  6<              (%build_ldflags)
  5<            (%build_ldflags)
  4<          (%build_ldflags)
  3<        (%build_ldflags)
  2<      (%build_ldflags)
  1<    (%build_ldflags)
  0<  (%build_ldflags)

I thin that this line should look like

RPM_LD_FLAGS=\"%{?build_ldflags:%{build_ldflags}}\"\ 

[pmatilai]

Referring to the macro itself in its body is recursion, which is why you get the error.

%{?build_ldflags:%{build_ldflags}} is exactly the same as %{?build_ldflags}.