Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'run haros as a test' function to CMake extras file? #13

Open
gavanderhoorn opened this issue Jun 4, 2019 · 2 comments
Open

Add 'run haros as a test' function to CMake extras file? #13

gavanderhoorn opened this issue Jun 4, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@gavanderhoorn
Copy link
Member

This would be similar to how roslint works where it adds a dependency to run_tests such that it gets run whenever run_tests is built.

See wiki/roslint - Reference for how that is used (the roslint_add_test entry).

Related code: https://github.com/ros/roslint/blob/6c963f3010c94d4b13123f468ce8ca4844ee20c4/cmake/roslint-extras.cmake.em#L70-L75.

@nlimpert
Copy link
Contributor

nlimpert commented Jun 6, 2019

I actually like the idea of using haros as a doc job in terms of being an independent static analysis tool to measure quality.
So I'm not entirely sure whether haros should be able to break a build.

@gavanderhoorn
Copy link
Member Author

It would be by choice of users, as they'd have to explicitly call haros_add_test() in their CMakeLists.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants