New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow Strip Marker #971

Open

rr-tom-noble opened this issue Apr 20, 2023 · 1 comment

Labels

rr-tom-noble commented Apr 20, 2023 •

edited

Loading

ROS2 port of this issue and PR, which I'm starting work on today.

@rhaschke when you have time, could you let me know the appropriate place(s) to put the changes made to the following files in the ROS1 PR:

.github/workflows/abi.yaml
.github/workflows/ci.yaml
src/rviz/default_plugin/marker_utils.cpp
src/test/send_arrow_strip_marker.py

I've noticed there are unit tests for the different marker types now, so I'll make sure to add some for the new type.

Contributor

rhaschke commented Apr 20, 2023

Sorry, I'm not involved in rviz2.

clalancette added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment