Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2 action send_goal shows incorrect goal UUID #857

Open
alsora opened this issue Sep 28, 2023 · 4 comments
Open

ros2 action send_goal shows incorrect goal UUID #857

alsora opened this issue Sep 28, 2023 · 4 comments
Labels
more-information-needed Further information is required

Comments

@alsora
Copy link
Contributor

alsora commented Sep 28, 2023

Bug report

Required Info:

  • Operating System:
    • Ubuntu 20.04
  • Installation type:
    • sources
  • Version or commit hash:
    • Galactic
  • DDS implementation:
    • Fast-DDS
  • Client library (if applicable):
    • rclpy

Steps to reproduce issue

Send a ROS 2 action goal from command line to an action server running in a C++ application.
The ROS 2 CLI prints a goal id when the goal is accepted.
Have the action server print the UUID of the goal using

rclcpp_action::to_string(goal_handle->get_goal_id())

Expected behavior

The UUID printed by the C++ action server and the UUID printed by the Python action client should match.

Actual behavior

The UUIDs are very similar but they do not match.
For example, the CLI shows:

Goal accepted with ID: b10a7c4d52564eafa06962e25eefe297

while the C++ app shows

b1a7c4d52564eafa06962e25eefe297

Note how the two string representations are very similar, but different.

The same applies to many other goals. It looks like there are always a couple of extra/missing zeros in the Python representation.

@clalancette
Copy link
Contributor

Can you please check with Rolling or Humble? I can't seem to make it happen with Rolling, but I may just be getting "lucky" and not generating UUIDs with 0s at the right spots.

@clalancette clalancette added the more-information-needed Further information is required label Oct 5, 2023
@Ryanf55
Copy link

Ryanf55 commented Feb 25, 2024

Trying to print the UUID with uuid_unparse results in a different value than what is reported in the CLI on humble. Would you like me to provide a minimum reproducible example?

@fujitatomoya
Copy link
Collaborator

@Ryanf55 yes please. for the information, does this also happen with rolling?

@Ryanf55
Copy link

Ryanf55 commented Feb 26, 2024

The code it's in is tied to humble. I'll extract a minimum example out and report test results on humble and rolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

No branches or pull requests

4 participants