Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python not being found for lttngpy in Windows debug mode #87

Merged

Conversation

christophebedard
Copy link
Member

Closes #86

I found this fix in a few other packages that use Python in CMake.

@christophebedard christophebedard self-assigned this Jan 11, 2024
@christophebedard
Copy link
Member Author

Trying a packaging_windows_debug job first:

  • packaging_windows_debug Build Status

@clalancette
Copy link
Contributor

Trying a packaging_windows_debug job first:

In general, we prefer not to use the packaging_* jobs for debugging. That's just so that they have a relatively "clean" history of what has happened nightly. Instead, we prefer to use https://ci.ros2.org/view/All/job/test_packaging_windows/ .

In this case, it has already been done, so you can just let it run. But just for future reference.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, assuming CI comes back green.

@christophebedard
Copy link
Member Author

Trying a packaging_windows_debug job first:

In general, we prefer not to use the packaging_* jobs for debugging. That's just so that they have a relatively "clean" history of what has happened nightly. Instead, we prefer to use https://ci.ros2.org/view/All/job/test_packaging_windows/ .

In this case, it has already been done, so you can just let it run. But just for future reference.

Oh, sorry! I should've looked for a test_* equivalent.

Seems like lttngpy now builds successfully, so let's run full CI, including a Windows debug job:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • Windows debug Build Status

@clalancette
Copy link
Contributor

Seems like lttngpy now builds successfully, so let's run full CI, including a Windows debug job:

Just so you know; we have other, unrelated failures in Windows Debug CI at the moment. So I expect that job will fail, but it should get past the compilation phase and into running tests before doing so.

@christophebedard
Copy link
Member Author

It ended up passing, probably because I only tested --packages-above lttngpy.

@clalancette clalancette merged commit db5ef98 into rolling Jan 12, 2024
8 of 9 checks passed
@clalancette clalancette deleted the christophebedard/fix-lttngpy-build-windows-debug branch January 12, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lttngpy fails to build on Windows Debug
2 participants