Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test_tracetools tests against rmw_zenoh_cpp #140

Draft
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Oct 10, 2024

Requires ros2/rmw_zenoh#294

This is a draft, because it requires having the Zenoh router running:

$ ros2 run rmw_zenoh_cpp rmw_zenohd

Also, this probably should not be merged before rmw_zenoh_cpp officially becomes a tier 1 rmw implementation and gets included in the ROS 2 core (and ros2.repos), although the rmw_zenoh_cpp will just be skipped if it's not found.

@christophebedard christophebedard self-assigned this Oct 10, 2024
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a draft, because it requires having the Zenoh router running

CI is gonna be responsible for this, right? unless, rmw_zenoh_cpp cannot run the CI or any tests? I do not really know what the plan here though...

@clalancette
Copy link
Contributor

CI is gonna be responsible for this, right? unless, rmw_zenoh_cpp cannot run the CI or any tests? I do not really know what the plan here though...

Yeah, we are going to have to figure out how to ensure that the router is running (both for ci.ros2.org and the Rpr jobs) so that the rmw_zenoh_cpp tests can run and pass.

@christophebedard
Copy link
Member Author

christophebedard commented Oct 10, 2024

In this case, I can easily launch zenohd before launching the nodes that get traced (e.g., in tracetools_test's TraceTestCase), but yeah we need a universal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants