Switch to ament_generate_version_header for tracetools #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <[email protected]>
wjwwood
approved these changes
Apr 15, 2024
|
fujitatomoya
approved these changes
Apr 16, 2024
|
@christophebedard windows failing https://ci.ros2.org/job/ci_windows/21551/console, can you check it? |
Signed-off-by: Christophe Bedard <[email protected]>
|
Weird. I think it might be due to the header The private definition for the version didn't exist anyway if |
|
I'll assume that the new change will be acceptable and kick off another round of CI:
|
christophebedard
deleted the
christophebedard/tracetools-use-ament-generate-version-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually defining a private compile definition.