Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing instrumentation to rmw_fastrtps_dynamic_cpp #772

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add tracing instrumentation to rmw_fastrtps_dynamic_cpp #772

merged 1 commit into from
Jul 8, 2024

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Jul 4, 2024 •
edited
Loading

rmw_fastrtps_cpp is already instrumented. Since some of the tracing instrumentation is in rmw_fastrtps_shared_cpp (thus covering both rmw_fastrtps_cpp and rmw_fastrtps_dynamic_cpp), instrumenting rmw_fastrtps_dynamic_cpp is rather simple.

Part of ros2/ros2_tracing#127

@christophebedard christophebedard mentioned this pull request Jul 4, 2024
Merged
fujitatomoya
fujitatomoya approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

ahcorde
ahcorde approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member Author

That .repos file is missing the ros2_tracing PR branch. Also, it looks like CI is ignoring rmw_fastrtps_dynamic_cpp by default.

CI with ros2/ros2_tracing#127 and with ✔️ CI_USE_FASTRTPS_DYNAMIC:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member Author

CI looks good. I'll let one of you merge this. Then I'll merge ros2/ros2_tracing#127 (it doesn't need to be merged at the same time as this rmw_fastrtps PR, but it does need to be merged after, not before).

@clalancette clalancette merged commit 549b411 into ros2:rolling Jul 8, 2024
3 checks passed
@clalancette
Copy link
Contributor

CI looks good. I'll let one of you merge this. Then I'll merge ros2/ros2_tracing#127 (it doesn't need to be merged at the same time as this rmw_fastrtps PR, but it does need to be merged after, not before).

Merged now, so please feel free to merge the tracing one.

@christophebedard christophebedard deleted the christophebedard/add-tracing-instrumentation-rmw-fastrtps-dynamic-cpp branch July 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@ahcorde ahcorde ahcorde approved these changes

@clalancette clalancette clalancette approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs

@sloretz sloretz Awaiting requested review from sloretz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophebedard @clalancette @ahcorde @fujitatomoya