Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin out tlsf_cpp and rttest and convert this repo to a hub for other realtime repositories #123

Open
nightduck opened this issue Jan 25, 2023 · 5 comments

Comments

@nightduck
Copy link

Feature request

Feature description

Convert this repository to a hub for for other real-time repositories. Ideally, it would house documentation and a repos file

Implementation considerations

tlsf_cpp and rttest would be spun out as their own repositories, possibly hosted in the https://github.com/ros-realtime group.

@clalancette
Copy link
Contributor

So I do think we should do some work here to separate the "real time" stuff we currently have from the core.

In particular, we currently have this repository (which provides rttest and tlsf_cpp), https://github.com/ros2/tlsf (which provides the tlsf package), and the demo using all of this in https://github.com/ros2/demos (pendulum_control and pendulum_msgs).

What we'd like to do is to move all of that out from the core, and basically have the realtime working group take over maintenance of it.

I can see two different ways of doing that:

  1. We can move tlsf, pendulum_control, and pendulum_msgs into this repository, and then have the realtime working group take over maintenance of this repository.
  2. We can move all of rttest, tlsf_cpp, tlsf, pendulum_control, and pendulum_msgs into the https://github.com/ros-realtime organization.

Either way, we would remove all of those packages from both https://github.com/ros2/ros2/blob/rolling/ros2.repos and https://github.com/ros2/variants/blob/master/desktop/package.xml , so they would no longer be considered a default part of the core. But they would still be available as packages to install, assuming that the realtime working group wants that.

Personally, I prefer 1; it is less churn, and achieves the same effect. But if the realtime working group really prefers 2, we can do that instead.

Thoughts?

@razr
Copy link

razr commented Feb 13, 2023

Personally, I prefer option 2. It will bring all real-time related stuff under one umbrella.
there is also https://github.com/ros2-realtime-demo/pendulum not sure whether it is the same as https://github.com/ros2/demos/tree/rolling/pendulum_control
@carlossvg @JanStaschulat

@clalancette
Copy link
Contributor

Personally, I prefer option 2. It will bring all real-time related stuff under one umbrella.

OK, if everyone agrees with this, then I'm happy to start the process.

there is also https://github.com/ros2-realtime-demo/pendulum not sure whether it is the same as https://github.com/ros2/demos/tree/rolling/pendulum_control

It looks like they are different things. The one that is currently in https://github.com/ros2/demos/tree/rolling/pendulum_control uses the rttest package to do some tracking of things like page faults, while running a pendulum controller. I'm not quite sure how (or if) it fits into the realtime working group repositories.

@razr
Copy link

razr commented Feb 13, 2023

@carlossvg
Copy link

@nightduck Should we update the description and go with option 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants