-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve message filters error messages #364
Conversation
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this!
Signed-off-by: Ivan Santiago Paunovic <[email protected]> Co-authored-by: Jacob Perron <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
…/geometry2 into ivanpauno/better-error-msgs
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this just improves the error message, but doesn't actual resolve the repeated warnings on start-up. I.e. it doesn't fix ros2/rviz#513 |
Sounds good, I don't know if that can be completely fixed though. |
Yeah, I don't know either. This might be something we could hack around in RViz if it seems to be annoying to users. It might be worth leaving the ticket open and report this improvement on the ticket at least. |
If I understand what you are talking about here, I think this is just a generic problem with tf2. See #358, which I think is related. This change is obviously an improvement so that the error messages are less generic. But I wouldn't be in favor of suppressing them in RViz, just because all other applications that use tf2 probably have similar issues. |
Replace some errors labeled as "unknown" with a more specific label.
Fixes ros2/rviz#443.
Fixes #118.