diff --git a/tf2_geometry_msgs/CMakeLists.txt b/tf2_geometry_msgs/CMakeLists.txt
index f14802b0a..cb02e3382 100644
--- a/tf2_geometry_msgs/CMakeLists.txt
+++ b/tf2_geometry_msgs/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.5)
+cmake_minimum_required(VERSION 3.20)
project(tf2_geometry_msgs)
# Default to C++17
@@ -10,13 +10,21 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic -Wnon-virtual-dtor -Woverloaded-virtual)
endif()
-# Figure out Python3 debug/release before anything else can find_package it
-if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL "Debug")
- find_package(python_cmake_module REQUIRED)
- find_package(PythonExtra REQUIRED)
- # Force FindPython3 to use the debug interpretter where ROS 2 expects it
- set(Python3_EXECUTABLE "${PYTHON_EXECUTABLE_DEBUG}")
-endif()
+# By default, without the settings below, find_package(Python3) will attempt
+# to find the newest python version it can, and additionally will find the
+# most specific version. For instance, on a system that has
+# /usr/bin/python3.10, /usr/bin/python3.11, and /usr/bin/python3, it will find
+# /usr/bin/python3.11, even if /usr/bin/python3 points to /usr/bin/python3.10.
+# The behavior we want is to prefer the "system" installed version unless the
+# user specifically tells us othewise through the Python3_EXECUTABLE hint.
+# Setting CMP0094 to NEW means that the search will stop after the first
+# python version is found. Setting Python3_FIND_UNVERSIONED_NAMES means that
+# the search will prefer /usr/bin/python3 over /usr/bin/python3.11. And that
+# latter functionality is only available in CMake 3.20 or later, so we need
+# at least that version.
+cmake_policy(SET CMP0094 NEW)
+set(Python3_FIND_UNVERSIONED_NAMES FIRST)
+
find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
find_package(geometry_msgs REQUIRED)
diff --git a/tf2_geometry_msgs/package.xml b/tf2_geometry_msgs/package.xml
index 3397023cf..54277597b 100644
--- a/tf2_geometry_msgs/package.xml
+++ b/tf2_geometry_msgs/package.xml
@@ -15,7 +15,6 @@
Wim Meeussen
ament_cmake
- python_cmake_module
geometry_msgs
orocos_kdl_vendor
diff --git a/tf2_py/CMakeLists.txt b/tf2_py/CMakeLists.txt
index a8e4e9ba8..2ab38f870 100644
--- a/tf2_py/CMakeLists.txt
+++ b/tf2_py/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.5)
+cmake_minimum_required(VERSION 3.20)
project(tf2_py)
# Default to C++17
@@ -21,13 +21,21 @@ if(CMAKE_COMPILER_IS_GNUCXX)
add_compile_options(-Wno-cast-function-type)
endif()
-# Figure out Python3 debug/release before anything else can find_package it
-if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL "Debug")
- find_package(python_cmake_module REQUIRED)
- find_package(PythonExtra REQUIRED)
- # Force FindPython3 to use the debug interpretter where ROS 2 expects it
- set(Python3_EXECUTABLE "${PYTHON_EXECUTABLE_DEBUG}")
-endif()
+# By default, without the settings below, find_package(Python3) will attempt
+# to find the newest python version it can, and additionally will find the
+# most specific version. For instance, on a system that has
+# /usr/bin/python3.10, /usr/bin/python3.11, and /usr/bin/python3, it will find
+# /usr/bin/python3.11, even if /usr/bin/python3 points to /usr/bin/python3.10.
+# The behavior we want is to prefer the "system" installed version unless the
+# user specifically tells us othewise through the Python3_EXECUTABLE hint.
+# Setting CMP0094 to NEW means that the search will stop after the first
+# python version is found. Setting Python3_FIND_UNVERSIONED_NAMES means that
+# the search will prefer /usr/bin/python3 over /usr/bin/python3.11. And that
+# latter functionality is only available in CMake 3.20 or later, so we need
+# at least that version.
+cmake_policy(SET CMP0094 NEW)
+set(Python3_FIND_UNVERSIONED_NAMES FIRST)
+
find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
find_package(ament_cmake REQUIRED)
@@ -41,7 +49,7 @@ python3_add_library(_tf2_py src/tf2_py.cpp)
if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL "Debug")
# python3_add_library should really take care of this for us, but it doesn't
- set_property(TARGET _tf2_py PROPERTY SUFFIX "_d.pyd")
+ set_target_properties(_tf2_py PROPERTIES DEBUG_POSTFIX "_d")
endif()
# Set output directories to import module from the build directory
diff --git a/tf2_py/package.xml b/tf2_py/package.xml
index 64fdf0a6d..52bb12163 100644
--- a/tf2_py/package.xml
+++ b/tf2_py/package.xml
@@ -14,7 +14,6 @@
Tully Foote
ament_cmake
- python_cmake_module
geometry_msgs
diff --git a/tf2_sensor_msgs/CMakeLists.txt b/tf2_sensor_msgs/CMakeLists.txt
index 181bde1af..12542c1b6 100644
--- a/tf2_sensor_msgs/CMakeLists.txt
+++ b/tf2_sensor_msgs/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.5)
+cmake_minimum_required(VERSION 3.20)
project(tf2_sensor_msgs)
# Default to C++17
@@ -10,13 +10,21 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic -Wnon-virtual-dtor -Woverloaded-virtual)
endif()
-# Figure out Python3 debug/release before anything else can find_package it
-if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL "Debug")
- find_package(python_cmake_module REQUIRED)
- find_package(PythonExtra REQUIRED)
- # Force FindPython3 to use the debug interpretter where ROS 2 expects it
- set(Python3_EXECUTABLE "${PYTHON_EXECUTABLE_DEBUG}")
-endif()
+# By default, without the settings below, find_package(Python3) will attempt
+# to find the newest python version it can, and additionally will find the
+# most specific version. For instance, on a system that has
+# /usr/bin/python3.10, /usr/bin/python3.11, and /usr/bin/python3, it will find
+# /usr/bin/python3.11, even if /usr/bin/python3 points to /usr/bin/python3.10.
+# The behavior we want is to prefer the "system" installed version unless the
+# user specifically tells us othewise through the Python3_EXECUTABLE hint.
+# Setting CMP0094 to NEW means that the search will stop after the first
+# python version is found. Setting Python3_FIND_UNVERSIONED_NAMES means that
+# the search will prefer /usr/bin/python3 over /usr/bin/python3.11. And that
+# latter functionality is only available in CMake 3.20 or later, so we need
+# at least that version.
+cmake_policy(SET CMP0094 NEW)
+set(Python3_FIND_UNVERSIONED_NAMES FIRST)
+
find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
find_package(eigen3_cmake_module REQUIRED)
diff --git a/tf2_sensor_msgs/package.xml b/tf2_sensor_msgs/package.xml
index 962ec8318..5d3e7db18 100644
--- a/tf2_sensor_msgs/package.xml
+++ b/tf2_sensor_msgs/package.xml
@@ -16,7 +16,6 @@
ament_cmake
eigen3_cmake_module
- python_cmake_module
eigen3_cmake_module