Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider extending NavSatFix with an optional orientation #104

Open
tfoote opened this issue Apr 8, 2020 · 3 comments
Open

consider extending NavSatFix with an optional orientation #104

tfoote opened this issue Apr 8, 2020 · 3 comments
Labels

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 8, 2020

This is a follwup to the pre Foxy Message API review

  • Comment: Consider replacing NavSatFix with gps_common/GPSFix or add some of the fields from GPSFix (the orientations specifically).
    This better supports dual antenna gps setups where an accurate heading can be provided and synced with the position fix.
  • Suggested Action:
    Consider a extending the message with an optional orientation. Or consider a new extended message with orientation added. This message is specifically generic to all GNSS systems versus the GPS one has GPS specific data so is not suitable to be replaced.
@Ryanf55
Copy link
Contributor

Ryanf55 commented Apr 4, 2023

Could this be targeted for ROS2 Iron? The Dual-antenna GPS receivers are becoming more popular in the aerial industry.

@SteveMacenski
Copy link
Contributor

I suggested potentially including a NavSatFixWithOrientation kind of message that combines them, in case we want to add a new message instead of modifying an old one. A NavSatFix by itself usually doesn't have orientation information for basic GPS systems. However, most new (non-cheapo) GNS systems in robotics have IMUs and such for better fusion, so I think that's worthy of consideration into sensor_msgs to include orientation to modernize.

@Ryanf55 can you bring this up in the GPS thread on discourse? It would be good to have everything in a single spot to compile a summary from once thoughts are collected

@Ryanf55
Copy link
Contributor

Ryanf55 commented Sep 14, 2023

I suggested potentially including a NavSatFixWithOrientation kind of message that combines them, in case we want to add a new message instead of modifying an old one. A NavSatFix by itself usually doesn't have orientation information for basic GPS systems. However, most new (non-cheapo) GNS systems in robotics have IMUs and such for better fusion, so I think that's worthy of consideration into sensor_msgs to include orientation to modernize.

@Ryanf55 can you bring this up in the GPS thread on discourse? It would be good to have everything in a single spot to compile a summary from once thoughts are collected

Reference: https://discourse.ros.org/t/future-of-ros-2-gps-support/33297/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants