Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.4 does not include the fix the missing BOOST FOREACH macro #403

Open
a1aw opened this issue Feb 15, 2023 · 3 comments
Open

1.7.4 does not include the fix the missing BOOST FOREACH macro #403

a1aw opened this issue Feb 15, 2023 · 3 comments

Comments

@a1aw
Copy link

a1aw commented Feb 15, 2023

Hi, I was compiling ros-noetic-desktop-full in my arch linux installation. And found that the latest 1.7.4 release does not include the fix eb8f009 for the missing BOOST FOREACH macro, causing me unable to compile this package.

The current boost version installed is 1.81.0

/home/anth/.cache/paru/clone/ros-noetic-pcl-ros/src/perception_pcl-1.7.4/pcl_ros/include/pcl_ros/point_cloud.h:231:15: error: there are no arguments to ‘BOOST_FOREACH’ that depend on a template parameter, so a declaration of ‘BOOST_FOREACH’ must be available [-fpermissive]
  231 |               BOOST_FOREACH(const pcl::detail::FieldMapping& fm, mapping) {
      |               ^~~~~~~~~~~~~

https://github.com/ros-perception/perception_pcl/blob/1.7.4/pcl_ros/include/pcl_ros/point_cloud.h

@SteveMacenski
Copy link
Member

SteveMacenski commented Feb 15, 2023

A release for Noetic was last done in Feb '22 (that commit is from July). Assuming PCL shouldn't be changing mid-distribution and you're compiling with the supported PCL version for your distribution per REP 2000, you should be compiling fine. If you're using a newer version, then yes, there can be issues with compatibility - since arbitrary versions of PCL are not officially supported (this is why we have REP 2000).

We can run a release though in the coming weeks. I generally overlook ROS 1 at this point since no new development is happening there across the ecosystem.

@mvieth
Copy link
Contributor

mvieth commented May 11, 2023

@SteveMacenski Are there still plans for a release?

@SteveMacenski
Copy link
Member

SteveMacenski commented May 18, 2023

It looks like @paulbovbel made a release for 1.7.5 about 4 months ago. Should/can that be released into bloom Paul?

@mvieth to be honest, I don't really keep track of ROS 1 anymore. Nav2 has blown so far past ROS Navigation I couldn't even imagine going back :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants