Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove theora transport #102

Open
ijnek opened this issue Jul 18, 2022 · 2 comments
Open

Remove theora transport #102

ijnek opened this issue Jul 18, 2022 · 2 comments

Comments

@ijnek
Copy link
Member

ijnek commented Jul 18, 2022

As discussed in #4 and #39, theora image transport seems to not be used at all and doesn't work...

As posted in 2013 - #4 (comment)

Fixing this would require to basically rewrite the whole plugin and design different message types that allow to resend headers and a certain rate and furthermore signal the content of each compressed image packet (header/data). Even this approach would be a hack since there are other streaming formats out there which encode "header" information along with the stream. Hence, since theora is kind of outdated, it would make more sense to focus on the integration of a more recent codes, such as vp8 into ROS.

If it never really worked, why not remove it? (Specifically on the ros2 branch)

@ijnek
Copy link
Member Author

ijnek commented Aug 7, 2022

Any of the maintainers have thoughts on this?

@ijnek
Copy link
Member Author

ijnek commented Mar 31, 2023

If there are no objections, I'm going to go ahead and deprecate theora_image_transport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant