Loading image_rotate::ImageRotateNode as component #820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that on the ROS 2 branches (at least for Humble, Galactic and Foxy) the
image_rotate::ImageRotateNode
is still exported with the
CLASS_LOADER_REGISTER_CLASS
macro:image_pipeline/image_rotate/src/image_rotate_node.cpp
Lines 364 to 367 in 975548a
Similarly to #691 the component is displayed when listing all component types with:
but results in a runtime error when trying to load it into a
component_container
This pull request fixes this by replacing the
CLASS_LOADER_REGISTER_CLASS
macro with theRCLCPP_COMPONENTS_REGISTER_NODE
macro and updatingimage_rotate::ImageRotateNode
's constructor to takeconst rclcpp::NodeOptions& options
as an argument.