Rectify plethora of changes in ROS1 and ROS2 versions

[SteveMacenski]

We've had alot of changes that are targeted at either ROS1 or ROS2 that have been changing quite alot, but nothing to homologate these changes together to make sure we have a consistent set of features and elements between ROS1 and ROS2.

[mikeferguson]

List of PRs to review (some might actually be in ROS 2 - but this is everything I see that isn't clearly in ROS 2 when doing a diff between noetic and rolling)

• [image_nodelet] change destroyWindow() to destroyAllWindows() #816
• Add option to use the RGB image timestamp for the registered depth image (rebased) #791
• added more aruco dicts, fixed aruco linerror bug #795
• Fixing thrown Exception in camerachecker.py #812 (may be needed?)
• Add option to prepend timestamp to image filename in image_saver node #806
• Update ROI parameters on resize #716 (already done)
• Add support for floating point fps #723
• support rgba8 and bgra8 encodings by skipping alpha channel #671
• Support MONO16 image encodings. #630
• resize.cpp: fix memory leak #489
• Fix OpenCV4 compatibility. #375
• depth_image_proc/point_cloud_xyzi_radial Add intensity conversion (copy) for float #336

[mikeferguson]

#863 ports #816 to ROS 2

[ahcorde]

• Add support for floating point fps Add support for floating point fps #866 (rolling)

[ahcorde]

• depth_image_proc/point_cloud_xyzi_radial Add intensity conversion (copy) for float ROS 2: depth_image_proc/point_cloud_xyzi_radial Add intensity conversion (copy) for float #867
• Support MONO16 image encodings: point_cloud_xyz Support MONO16 image encodings: point_cloud_xyz #868
• support rgba8 and bgra8 encodings by skipping alpha channel support rgba8 and bgra8 encodings by skipping alpha channel #869
• Add option to prepend timestamp to image filename in image_saver node: ROS 2: Add option to prepend timestamp to image filename in image_saver node #870
• Fixing thrown Exception in camerachecker.py ROS 2: Fixing thrown Exception in camerachecker.py #871
• Add option to use the RGB image timestamp for the registered depth image ROS 2: Add option to use the RGB image timestamp for the registered depth image #872
• added more aruco dicts, fixed aruco linerror bug ROS 2: Added more aruco dicts, fixed aruco linerror bug #873
• resize.cpp: fix memory leak ROS 2: Merged resize.cpp: fix memory leak #874

[mikeferguson]

@ahcorde - are you planning to do the last one on this list? (OpenCV4 compatibility - possible some of this is already in rolling, which makes it harder to actually resolve the diff)

[ahcorde]

@ahcorde - are you planning to do the last one on this list? (OpenCV4 compatibility - possible some of this is already in rolling, which makes it harder to actually resolve the diff)

I was checking this PR, Humble is supported from Ubuntu Focal and Debian Bullseye which I think we can only install OpenCV4 (not sure about OpenCV3). All the changes are already made, which means that these packages can compile with OpenCV 3 and 4

[mikeferguson]

Awesome - in that case - I'll assume we've ported whatever was needed - and AFAICT that means we have feature parity with ROS 1 and ROS 2 and we can close this ticket!