Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera_info_manager_py to this repo? #331

Closed
civerachb-cpr opened this issue Nov 20, 2024 · 3 comments
Closed

Add camera_info_manager_py to this repo? #331

civerachb-cpr opened this issue Nov 20, 2024 · 3 comments

Comments

@civerachb-cpr
Copy link

Back in the distant past there was a camera_info_manager_py package: https://github.com/ros-perception/camera_info_manager_py. It seems this repo has been effectively abandoned, with the last commits being about 8 years ago.

We've forked that repo and are trying to get it re-released for Humble and Jazzy, since it's a dependency of the axis_camera driver, which we'd also like to get released. However, we're getting some pushback from OSRF about releasing a fork of the original package. They've proposed that rather than releasing our fork, that they'd like to see camera_info_manager_py merged here and released by your team. See: ros/rosdistro#43325 (comment)

Are you open to this? If so, I can open merge requests against your Jazzy and Humble branches to add the new package, and then hopefully you can bloom the repo to get it released officially through OSRF's buildfarm.

Conversely, if you don't want to take ownership of camera_info_manager_py, or have some alternative proposal to get it released, could you please leave a comment on ros/rosdistro#43325?

Thanks!

@ahcorde
Copy link
Collaborator

ahcorde commented Nov 22, 2024

Hi @civerachb-cpr,

please open the PR with the camera_info_manager_py package, I will take care of blooming the package and possible PRs.

@civerachb-cpr
Copy link
Author

@ahcorde , done! I've made two MRs, one for humble and one for jazzy:

We've been using the clearpathrobotics/camera_info_manager_py/ros2 branch successfully for both distros, so the code is identical. I've set the camera_info_manager_py package version to match with the current version of the other packages in each branch to hopefully make blooming easier for you.

@ahcorde ahcorde closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants