Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we merge with bohr now ? #21

Open
minlingc opened this issue Jul 12, 2017 · 6 comments
Open

Can we merge with bohr now ? #21

minlingc opened this issue Jul 12, 2017 · 6 comments

Comments

@minlingc
Copy link

@shaun-edwards @AmyMingli @phvass @AustinDeric

Shaun, ready merge this?

Thanks, Min Ling

@shaun-edwards
Copy link
Collaborator

Can you open a PR. If it's a large PR, you may want to break it up into logical chunks/packages.

@minlingc
Copy link
Author

@AmyMingli can you open a PR to merge to bohr please?

@AmyMingli
Copy link

@minlingc @shaun-edwards The pull request for the readme file has been created last October here: https://github.com/ros-industrial-consortium/bohr_devel/pulls . Let me know if there is any misunderstanding..

@shaun-edwards
Copy link
Collaborator

@AmyMingli, the MR is for bohr (one appears to be an empty (no changes) MR, the other has conflicts). This is the packml repo. I thouht @minlingc's question was merging bohr into packml. As far as I know, there doesn't exist an MR for that.

@minlingc
Copy link
Author

sorry merge packml into bohr.
As this is the name selected by one of the sponsors.

@AmyMingli
Copy link

@shaun-edwards I just create another PR to bohr repo to update the README file. Can you take a look and merge it if it is ok?
@minlingc I don't think I can merge packml into bohr, as I don't have writing access to either bohr or packml repo. And when the merge is done by another Administrator, the README file also need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants