-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate frame difference #93
base: master
Are you sure you want to change the base?
Calculate frame difference #93
Conversation
std::vector<double> & x_a_vec, std::vector<double> & x_b_vec, double dt, | ||
std::vector<double> & delta_x_vec); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not imbibe the size constraints?
std::vector<double> & x_a_vec, std::vector<double> & x_b_vec, double dt, | |
std::vector<double> & delta_x_vec); | |
std::array<double, 7> & x_a_vec, std::array<double, 7> & x_b_vec, double dt, | |
std::array<double, 6> & delta_x_vec); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used std::vector<double>
to maintain consistency with the convert_joint_deltas_to_cartesian_deltas
method, where std::vector<double>
is used for the delta_x
parameter.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 80.20% 80.00% -0.21%
==========================================
Files 4 4
Lines 197 245 +48
Branches 35 52 +17
==========================================
+ Hits 158 196 +38
- Misses 28 34 +6
- Partials 11 15 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR introduces a method to compute frame differences, along with a corresponding KDL implementation.