Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove sensitive data from vcr #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RichardLitt
Copy link
Contributor

Closes #115.

@slager
Copy link
Collaborator

slager commented Oct 11, 2024

Are the changes in test-ebirdgeo.R intentional?

@RichardLitt
Copy link
Contributor Author

Yes. They make sure that getlatlng at least doesn't throw an error when it runs. I wasn't sure how to test the regex fix.

@slager
Copy link
Collaborator

slager commented Oct 11, 2024

I don't see how these added lines accomplish that?

expect_error()
expect_no_warning('amegfi')

@RichardLitt RichardLitt force-pushed the feat/remove-sensitive-data-from-vcr-using-regex branch from cf25541 to a80acf4 Compare October 11, 2024 03:17
@RichardLitt
Copy link
Contributor Author

You're right. It doesn't provide the coverage I wanted.

I think there should be a vcr response for if http://ipinfo.io returns nothing, as that isn't covered in the current tests, I think.

@sebpardo
Copy link
Contributor

Hi @RichardLitt, where are you at with this? I've tried running these tests locally and they seem to be blocking IP addresses as expected.

@RichardLitt
Copy link
Contributor Author

I removed the unnecessary lines, and this should be good to go if it works for you. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IP-based location determination?
3 participants