-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cloud storage support #300
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing this code! Can we get an idea of the status of this code, for example, is it being used in any application? Any insights into where/how/scale of thie code being used would be great. |
cloud/aws/aws_s3.cc
Outdated
@@ -688,7 +688,7 @@ IOStatus S3StorageProvider::ExistsCloudObject(const std::string& bucket_name, | |||
IOStatus S3StorageProvider::GetCloudObjectSize(const std::string& bucket_name, | |||
const std::string& object_path, | |||
uint64_t* filesize) { | |||
HeadObjectResult result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get rid of this change, this is not needed and makes the diff large in size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This pull request (PR) originates from MonographDB. In our current setup, we utilize RocksDB Cloud as the log server backend to store log items, and the S3 backend has been performing effectively. Now, we aim to expand our support to Google Cloud, which serves as the motivation for creating this PR. Although the integration work is still in progress, we anticipate its completion in the near future and are actively working towards its resolution. |
Would be great to get this in! |
Thanks for the great contribution. Some minor comments within. |
This is my CLA issue I notice there are some conflicting files, I will fix them later. |
@airhorns are you using this patch now? if so let us know the size and scale of your testing on google cloud |
56474da
to
90eac14
Compare
Rebase gcs_support onto rockset:master. Here are the test results: (All test cases passed, except those excluded by -gtest_filter, which also failed on rockset:master.)
|
This pull request introduces support for Google Cloud Storage as an optional storage backend. Users can enable this feature by using the compile flag USE_GCP. Additionally, the USE_GCP flag can be used in conjunction with the USE_AWS flag to enable both the S3 and GCS storage backends simultaneously. To validate this feature, two new test suites, namely gcp_db_cloud_test and gcp_file_system_test, have been created.
Here are the steps to set up and run this feature: