Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turtlebot/3ea2c30: liveness seems far fetched #429

Closed
gavanderhoorn opened this issue Jun 30, 2021 · 1 comment
Closed

turtlebot/3ea2c30: liveness seems far fetched #429

gavanderhoorn opened this issue Jun 30, 2021 · 1 comment
Labels
bug-descriptions help wanted Extra attention is needed

Comments

@gavanderhoorn
Copy link
Member

turtlebot/3ea2c30 is labelled SOFTWARE:LIVENESS. This seems hard to justify given the description:

title: Environment Hooks Introduce Undocumented Dependency
description: >
ROS packages can make use of environment hooks -- shell scripts
that are executed, for instance, to set up environment variables.
In ROS Indigo, the core Turtlebot package introduced an
environment hook that depended on another package that was not
listed as a dependency in the package manifest. This caused error
messages to be printed to the terminal if the user did not have
the package installed.
The fix was to move the faulty parts of the environment hook to
the package they depended on.

The user reporting the bug essentially describes he gets a warning, but does not mention any loss of functionality, nor any components which fail to function properly.

He's not using the components which depend on the bit of script which is not working (ie: the environment hook): the navigation stack would depend on the TURTLEBOT_MAP_FILE env var being set, but he doesn't use it.

LOSS-OF-CONTROL is even harder to justify: if this were a completely automated system, the map not being configured for the navigation stack could certainly lead to the robot not being able to navigate, but it would not even start up (ie: it would never have control, so it can't lose it).

@gavanderhoorn gavanderhoorn added help wanted Extra attention is needed bug-descriptions labels Jun 30, 2021
@gavanderhoorn
Copy link
Member Author

Apparently I'd already posted this.

Closing as a duplicate of #415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-descriptions help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant