Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovered root policy does not know about new bridges, filesystem changes #197

Open
reynir opened this issue Nov 20, 2024 · 3 comments
Open

Comments

@reynir
Copy link
Contributor

reynir commented Nov 20, 2024

In #190 a discovered root policy was introduced. This examines the total disk space and what network bridges exist. This has the unfortunate effect that newly created bridges are not usable by albatross. On the other hand it has the positive effect that bridges that are created by other services that are launched after albatross are not usable by albatross, for example bridges created by libvirt or docker.

Similarly, this doesn't observe changes to the filesystem. Today, I created a 64 GB filesystem for /var/lib/albatross/block, but the root policy says 40 GB as is the size of the root filesystem.

@hannesm
Copy link
Collaborator

hannesm commented Nov 20, 2024

Thanks for your report. Yes, indeed, there are limitations. But I wonder what should be done... we can busily loop for detecting changes, but then if e.g. mollymawk is connected, it would as well busily need to gather the root policy...

With the current behaviour, albatross needs to be restarted if the bridges / file system changes.

@reynir
Copy link
Contributor Author

reynir commented Nov 20, 2024

I'm as well unsure what to do. One way could be to re-discover the root policy on every policy operation. I'm not sure I like that approach. It would also result in mollymawk having to do more queries to albatross.

Perhaps it is sufficient to just document this behavior.

@hannesm
Copy link
Collaborator

hannesm commented Nov 20, 2024

The question is not only what to do if block storage has increased in size / new network bridges are available, but as well what to do when block storage size gets decreased / bridges are removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants