Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of analogServer #358

Open
lrapetti opened this issue Sep 28, 2023 · 17 comments
Open

Replace usage of analogServer #358

lrapetti opened this issue Sep 28, 2023 · 17 comments
Assignees

Comments

@lrapetti
Copy link
Member

lrapetti commented Sep 28, 2023

Currently we are using the analogServer in order to stream the wrench data from IHumanWrench interface (see https://github.com/search?q=repo%3Arobotology%2Fhuman-dynamics-estimation%20analogServer&type=code). However, the analogServer corresponds to the analogWrapper mentioned in robotology/yarp#2999, which will be soon be deprecated.

Indeed we should understand what are the alternatives. One option could be to implement our own message, and wrapper/remapper devices as we are doing for the IHumanState and IHumanDynamics, and removing the IAnalogSensor interface from the wrench provider (see here). Clearly this will also break the ROS pipeline, which anyway should be soon addressed (see also #335).

Another option, would be to understand what is the alternative device.

@lrapetti
Copy link
Member Author

cc @traversaro

@traversaro
Copy link
Member

For the ROS part, you can use WrenchStampedRosPublisher as long as you expose the data also with a yarp::dev::ISixAxisForceTorqueSensors. For the YARP part, who is using /HDE/HumanWrenchPublisher/wrench:o ? There is any assumption that the data is in vector form?

@lrapetti
Copy link
Member Author

For the YARP part, who is using /HDE/HumanWrenchPublisher/wrench:o ? There is any assumption that the data is in vector form?

I think that specific port is not used, but there is a second analogServer here publishing on /HDE/HumanWrenchWrapper/wrench:o. That port is generally used by the visualizer assuming it's a vector (see here). In case we develop dedicated wrapper/remapper (nws/nwc), we can easily change that part and it would probably also improve the readability. I don't know if you already had in mind another alternative solution.

@lrapetti
Copy link
Member Author

I have opened #361 to address the replacement of analogServer for what concern the YARP messages. It will remain the analogServer to stream data in ROS which should be replaced.

@lrapetti lrapetti self-assigned this Sep 28, 2023
@claudia-lat
Copy link
Contributor

I think we can close this issue, am I right?

@traversaro
Copy link
Member

Apparently three files are still using that:

I would remove the files before closing the issue. If instead the files are still used, then we have a problem. fyi @S-Dafarra @mebbaid

@S-Dafarra
Copy link
Contributor

Apparently three files are still using that:

I would remove the files before closing the issue. If instead the files are still used, then we have a problem. fyi @S-Dafarra @mebbaid

I think this is similar to what @dariosortino did for the iFeel part. Those wrappers were useful to stream over ROS the values of the shoes I suppose. I doubt they work anyhow, since the ROS group has disappeared from recent versions of the device.

@mebbaid
Copy link
Contributor

mebbaid commented May 10, 2024

As far as I know

  • on the human.xml side, the main users are the iFeel human wrenches visualization guys. I think they already moved from streaming the data in that way @dariosortino may confirm.
  • The PHRI XML files were used by @lrapetti for his experiments. Those same experiments will be reproduced by @CarlottaSartore and in this case it maybe a good chance to remove them and adapt to new versions of the device

@dariosortino
Copy link
Collaborator

  • on the human.xml side, the main users are the iFeel human wrenches visualization guys. I think they already moved from streaming the data in that way @dariosortino may confirm.

Sorry but about this I don't really know much what's going on currently

@traversaro
Copy link
Member

  • on the human.xml side, the main users are the iFeel human wrenches visualization guys. I think they already moved from streaming the data in that way @dariosortino may confirm.

Sorry but about this I don't really know much what's going on currently

I guess it all boils down to which files you are using in the iFeel-Human demos. If you are not using

<device type="analogServer" name="HumanWrenchPublisher">
anymore, then I guess we can remove them. fyi @claudia-lat @GiulioRomualdi

@dariosortino
Copy link
Collaborator

Checking in our configuration files, it seems that we don't use that anymore

@traversaro
Copy link
Member

Perfect, I guess we can delete the human.xml in this repo then.

@lrapetti
Copy link
Member Author

lrapetti commented May 13, 2024

  • The PHRI XML files were used by @lrapetti for his experiments. Those same experiments will be reproduced by @CarlottaSartore and in this case it maybe a good chance to remove them and adapt to new versions of the device

Those file are actually older, I think they were used for An.Dy demo before I even joined! Concerning Human.xml that's the file that was used for Xsens, I don't know if it might still be needed.

@dariosortino
Copy link
Collaborator

@traversaro
Copy link
Member

It would be nice also to correct this https://github.com/robotology/human-dynamics-estimation/blob/master/misc/hde_scheme.png

@lrapetti do you happen to know where the source of that drawing is?

@claudia-lat
Copy link
Contributor

@traversaro I've got the .svg of the scheme, I will fix it together with @davidegorbani.

@mebbaid
Copy link
Contributor

mebbaid commented May 13, 2024

you can use the updated figure discussed in the handover in https://github.com/ami-iit/element_ergonomy-control/issues/183#issuecomment-1872496045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants