Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConcurrentInstancesTest and ControlBoardOnMultipleGazeboInstancesTest non-deterministic crash #201

Closed
traversaro opened this issue Aug 21, 2024 · 2 comments · Fixed by #202

Comments

@traversaro
Copy link
Member

Similar to #200, these two tests still crash non deterministically. Unfortunately, the problem is upstream in gz-physics/dartsim/ode (see gazebosim/gz-sim#18 and #153) .

While this does not fix the problem in general, I think we should at least switch to another DART's collision detector (not ODE, that has this multithreading problems) in the tests, to ensure that they run reliably.

@traversaro
Copy link
Member Author

Apparently the world already have some tags:

        <physics type="ignored">
            <dart>
                <collision_detector>dart</collision_detector>
            </dart>
        </physics>

but as the tests are still failing with ode-related errors, probably they are not read correctly.

@traversaro
Copy link
Member Author

traversaro commented Aug 21, 2024

Apparently the world already have some tags:

        <physics type="ignored">
            <dart>
                <collision_detector>dart</collision_detector>
            </dart>
        </physics>

but as the tests are still failing with ode-related errors, probably they are not read correctly.

The reason is described (and fixed [or actually worked around, the real fix would be to remove non-thread safe functions from ODE]) in gazebosim/gz-physics#675 . However, even if the PR is accepted it will take some time to get release, for the time being we can continue with --repeat until-success:20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment