Fix handling partials from standalone < tags. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the < tag is standalone, each non-empty line of the partial should be indented before it is rendered. The spec actually says all lines, not specifically non-empty ones. But the spec tests expect this and I've verified that other implementations (e.g. Pystache) does it this way. 3 more test cases now pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the < tag is standalone, each non-empty line of the partial should be indented before it is rendered. The spec actually says all lines, not specifically non-empty ones. But the spec tests seems to expect only non-empty ones to be indented, and I've verified that other implementations (e.g. Pystache) do it this way.
3 more test cases now pass. The remaining failures are all related to dotted names and implicit iterators, which are not supported yet. I have no pressing need for them so I might take a break here :)