Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvements #103

Open
4 of 5 tasks
robertapplin opened this issue Mar 20, 2021 · 0 comments
Open
4 of 5 tasks

Code Improvements #103

robertapplin opened this issue Mar 20, 2021 · 0 comments

Comments

@robertapplin
Copy link
Owner

robertapplin commented Mar 20, 2021

Some improvements/changes can be made to some parts of the code in this repo:

  • cpp The copy constructor and equals assignment operator should probably be deleted in the NBodySimulator because it has a member variable which is a vector of unique ptrs.
  • cpp const & on some of the return types can be used.
  • Primitive data types passed as parameters to functions can be const.
  • Pass by Value in Constructors as explained in Pass Parameters by value for Constructor #113
  • Convert cpp code to use C++ 20 . Some things to improve include:
    - Using std::erase_if instead of std::remove_if and std::erase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant