Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command injection due to legacy code #4733

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Fix command injection due to legacy code #4733

merged 2 commits into from
Nov 24, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Nov 24, 2024

do not squash

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Fixes a command injection which is triggered by rizin.c when RzBinInfo.rclass is fs and RzBinInfo.bclass contains the payload which is passed to rz_core_cmdf.

This PR also refactors the pebble parser to ensure endianness compatibility on different hosts.

@wargio wargio changed the title Fix command injection due legacy code Fix command injection due to legacy code Nov 24, 2024
@XVilka XVilka merged commit db6c5b3 into dev Nov 24, 2024
47 of 48 checks passed
@wargio wargio deleted the fix-cmd-injection branch November 24, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants