-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coloring help output of rizin,rz-diff,rz-asm #4046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run clang format
be sure to run the correct clang format. requires clang format 16 and then run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byteninjaa0 this PR contains a lot of unrelated changes, please remove those
4e74600
to
1df6993
Compare
how to solve this conflicts |
Just edit the file when rebasing. |
a6f4477
to
eb47f71
Compare
i have run the clang-format-16 but to make the source code more cleaner i have formatted the help strings manually. |
i think the clang format check is failing because i have manually formatted the help string to maintain cleaner codebase |
f6c65f6
to
13f17b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the function and rebase on top of the latest dev
. Apart from that LGTM.
ba04ba1
to
53a5b83
Compare
Your checklist for this pull request
Detailed description
colored help output of rizin, rz-diff,rz-asm
...
Test plan
...
Closing issues
...