Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move grep from RzCons to RzCore #3243

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Dec 13, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Move ~ (grep) handling from RzCons to RzCore
  • Minor refactoring and cleanup

Test plan

CI is green

Closing issues

Closes #1824
Partially addresses #276

Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember right now... What is the reasoning to have grep in RzCore and not in RzCons? What are the advantages?

@XVilka
Copy link
Member Author

XVilka commented Dec 14, 2022

@ret2libc to make it a part of the syntax and allow nesting, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move librz/cons/grep.c (~) command from the RzCons to the RzCore
2 participants