Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert pp commands to the rzshell #3112

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Convert pp commands to the rzshell #3112

merged 1 commit into from
Nov 7, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Oct 20, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Convert all pp commands to rzshell

Test plan

CI is green

Closing issues

Partially addresses #1590

@XVilka XVilka added this to the 0.5.0 milestone Oct 20, 2022
@XVilka XVilka mentioned this pull request Oct 20, 2022
Open
32 tasks
wargio
wargio reviewed Oct 20, 2022
View reviewed changes
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
wargio
wargio requested changes Oct 20, 2022
View reviewed changes
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Show resolved Hide resolved
librz/core/cmd/cmd_print.c Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
@XVilka XVilka force-pushed the asan-print-pattern-rzshell branch 2 times, most recently from 453cc46 to f01335d Compare October 20, 2022 16:21
wargio
wargio approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, besides the overflows. maybe limit the max len

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2022
View reviewed changes
librz/core/cmd/cmd_print.c Fixed Show fixed Hide fixed
librz/core/cmd/cmd_print.c Fixed Show fixed Hide fixed
ret2libc
ret2libc reviewed Oct 21, 2022
View reviewed changes
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
wargio
wargio approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure if there are tests for this, but i'm ok with the changes

@XVilka XVilka merged commit 431d2dd into dev Nov 7, 2022
@XVilka XVilka deleted the asan-print-pattern-rzshell branch November 7, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
RzCore
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@XVilka @wargio @ret2libc