Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port command pb/B to new shell #2828

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Port command pb/B to new shell #2828

merged 4 commits into from
Jul 28, 2022

Conversation

PeiweiHu
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • port command pb/B to new shell

Test plan

CI is green.

Closing issues

partially address #1590

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary newline:


[XX] db/cmd/cmd_0 pB 0
RZ_NOPLUGINS=1 /usr/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -Qc 'pB 0' bins/elf/analysis/hello-arm32
-- stdout
--- expected
+++ actual
@@ -1,0 +1,1 @@
+
[XX] db/cmd/cmd_0 pb 0
RZ_NOPLUGINS=1 /usr/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -Qc 'pb 0' bins/elf/analysis/hello-arm32
-- stdout
--- expected
+++ actual
@@ -1,0 +1,1 @@
+

Apart from that, looks good.

librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just those smaller things, but it's ok except them.

librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
@XVilka XVilka added the waiting-for-author Used to mark PRs where more work is needed label Jul 27, 2022
@XVilka XVilka merged commit 7f02a45 into rizinorg:dev Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rz-test RzCore waiting-for-author Used to mark PRs where more work is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants