Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port command p6 to new shell #2819

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Port command p6 to new shell #2819

merged 3 commits into from
Jul 19, 2022

Conversation

PeiweiHu
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • port command p6[d/e] to new shell
  • add test for command p6[d/e]

Test plan

CI is green.

Closing issues

partially address #1590

XVilka
XVilka requested changes Jul 19, 2022
View reviewed changes
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
@XVilka XVilka mentioned this pull request Jul 19, 2022
Open
32 tasks
ret2libc
ret2libc requested changes Jul 19, 2022
View reviewed changes
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
@PeiweiHu
Copy link
Contributor Author

@ret2libc Thanks! The code is neater.

@XVilka XVilka merged commit 9a75679 into rizinorg:dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@XVilka XVilka XVilka approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
rz-test RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeiweiHu @XVilka @ret2libc