Convert `d` commands to rzshell #2263

imbillow · 2022-01-28T14:58:08Z

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

Partially addresses #1342

librz/core/cmd_descs/cmd_debug.yaml

- remove `dtdi`, Because his function is the same as `dtd`

move `"de", " [perm] [rm] [addr|reg|from..to]", "Stop on condition"` to `dee`

move `"dL", " <handler>", "Set debugger handler"` to `dLs`

move `"dk?", "<signal>", "Name/signum resolver"` to `dkr`

ret2libc

Thanks for this, it will really help to have this merged!

I think right now the changes are really a lot and hard to review well though. Would it be feasible for you to split this PR into smaller ones? For example, start by converting dd commands, then dmi, etc. etc. Otherwise it becomes hard for me and others to review all changes and it may take a very long time to merge this.

It would be awesome to have this in.

librz/core/cmd_descs/cmd_debug.yaml

ret2libc · 2022-03-14T14:37:53Z

librz/core/cmd_descs/cmd_debug.yaml

+      - name: dd
+        summary: >
+          List file descriptors or Open
+          / Open and map that file into the UI
+        cname: cmd_debug_dd
+        args:
+          - name: file
+            type: RZ_CMD_ARG_TYPE_FILE
+            optional: true


Split this into ddl (list file descriptors) and dd <file> (Open and map that file)

I think the "UI" part is wrong? What does it mean?

I don't even know what it means.

rizin/librz/core/cmd/cmd_debug.c

Lines 71 to 72 in b3de515

"dd", "", "List file descriptors",

"dd", " <file>", "Open and map that file into the UI",

librz/core/cmd_descs/cmd_debug.yaml

ret2libc · 2022-03-14T14:57:32Z

librz/core/cmd_descs/cmd_debug.yaml

+            summary: List closest symbol to the current address
+            cname: cmd_debug_dmid
+            args: []
+      #          - name: dmiv


why commented?

rizin/librz/core/cmd/cmd_debug.c

Lines 1232 to 1239 in b3de515

case ' ': // "dmi "

case '*': // "dmi*"

case 'v': // "dmiv"

case 'j': // "dmij"

case 'q': // "dmiq"

case 'a': // "dmia"

{

const char *libname = NULL, *symname = NULL, *a0;

Because they were processed together in the original, and then it still use RZ_MODE_SIMPLE, RZ_MODE_JSON, but now we seem to use RzOutputMode.
And I haven't completely changed this part dmi.

dmiv seems to be just an alias for dmm

librz/core/cmd_descs/cmd_debug.yaml

Co-authored-by: Riccardo Schirone <[email protected]>

move "List file descriptors" to `ddl` merge `dd*` to `ddl` `type: RZ_CMD_DESC_TYPE_ARGV_STATE`

…into asan-debug-rzshell

- use `oo` to replace `do`

…]]]` remove dmiv

ret2libc

Any chance you could split this PR in smaller ones?

librz/core/cmd/cmd_shell.c

librz/core/cmd_descs/cmd_shell.yaml

imbillow · 2022-03-16T15:54:17Z

Any chance you could split this PR in smaller ones?

I want to fix all the tests first.

XVilka · 2022-05-09T13:58:29Z

@imbillow shall we close this one then?

imbillow · 2022-05-09T14:31:18Z

@imbillow shall we close this one then?

yes

debug rzshell sketch

e3f9b01

github-actions bot added the RzCore label Jan 28, 2022

XVilka requested changes Jan 29, 2022

View reviewed changes

librz/core/cmd_descs/cmd_debug.yaml Outdated Show resolved Hide resolved

XVilka added shell refactor Refactoring requests labels Jan 29, 2022

imbillow added 25 commits January 29, 2022 22:32

remove spaces within brackets

78cdf36

Merge branch 'dev' into asan-debug-rzshell

63a1b47

comment for every handler

eae5cbc

dt*:

a5a2d47

- remove `dtdi`, Because his function is the same as `dtd`

dd*

df40087

fix dd*

e6998c3

di* dH dg

ea9881d

remove help_msg_dts

6591e58

fix

77778a2

de*

bb5716f

move `"de", " [perm] [rm] [addr|reg|from..to]", "Stop on condition"` to `dee`

dL*

1c42cc5

move `"dL", " <handler>", "Set debugger handler"` to `dLs`

dk*

259a7be

move `"dk?", "<signal>", "Name/signum resolver"` to `dkr`

do*

a0ec7a6

remove code that is no longer used

5405d04

dp*

84eb01b

dx*

90d0504

d[wW]*

8d08438

use RZ_LOG_ERROR to replace eprintf

38e7835

make some RZ_LOG_ERROR become rz_cons_printf

6f6e4bb

move dLs back to dL

acb7703

fix

d8db1d8

fix

b3d4c5f

fix

598b488

dcs

8e69b8c

dmi* looks messy needs more refactoring

4108cb0

ds*

7447d14

XVilka assigned ret2libc Mar 14, 2022

ret2libc reviewed Mar 14, 2022

View reviewed changes

imbillow and others added 10 commits March 15, 2022 05:57

Update librz/core/cmd_descs/cmd_debug.yaml

205f016

Co-authored-by: Riccardo Schirone <[email protected]>

Update librz/core/cmd_descs/cmd_debug.yaml

eda8cb9

Co-authored-by: Riccardo Schirone <[email protected]>

Update librz/core/cmd_descs/cmd_debug.yaml

b859022

Co-authored-by: Riccardo Schirone <[email protected]>

Update librz/core/cmd_descs/cmd_debug.yaml

4c5d946

Co-authored-by: Riccardo Schirone <[email protected]>

dcs* -> dcst

12f404e

move "List file descriptors" to `ddl` merge `dd*` to `ddl` `type: RZ_CMD_DESC_TYPE_ARGV_STATE`

Merge branch 'asan-debug-rzshell' of https://github.com/rizinorg/rizin …

21bfe13

…into asan-debug-rzshell

remove ddt dk <signal>=<x> dko do

578a9dd

- use `oo` to replace `do`

split dk in two commands: dkl and dk <signal>

f597c1b

move dif from cmd_debug to cmd_shell and rename to diff

62600a1

move dmia [<libname> [<symname>]] to `dmi [-a [<libname> [<symname>…

b279574

…]]]` remove dmiv

imbillow force-pushed the asan-debug-rzshell branch from c42ae8b to b279574 Compare March 15, 2022 00:22

imbillow added 2 commits March 15, 2022 08:45

fix

385ae6d

fix

eda572b

ret2libc reviewed Mar 16, 2022

View reviewed changes

librz/core/cmd/cmd_shell.c Outdated Show resolved Hide resolved

librz/core/cmd_descs/cmd_shell.yaml Outdated Show resolved Hide resolved

librz/core/cmd_descs/cmd_shell.yaml Outdated Show resolved Hide resolved

imbillow added 2 commits March 17, 2022 00:04

fix

c10f2b1

fix dmi

8ab826e

imbillow mentioned this pull request Mar 16, 2022

Convert dt commands to rzshell #2418

Merged

5 tasks

This was referenced Apr 30, 2022

Convert to newshell do #2573

Merged

Convert ds commands to the rzshell #2574

Merged

imbillow closed this May 9, 2022

wargio deleted the asan-debug-rzshell branch May 9, 2022 15:34

imbillow restored the asan-debug-rzshell branch May 12, 2022 09:34

imbillow deleted the asan-debug-rzshell branch May 12, 2022 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert `d` commands to rzshell #2263

Convert `d` commands to rzshell #2263

imbillow commented Jan 28, 2022 •

edited by XVilka

Loading

ret2libc left a comment

ret2libc Mar 14, 2022

imbillow Mar 14, 2022

ret2libc Mar 14, 2022

imbillow Mar 14, 2022

imbillow Mar 14, 2022

ret2libc left a comment

imbillow commented Mar 16, 2022 •

edited

Loading

XVilka commented May 9, 2022

imbillow commented May 9, 2022

	"dd", "", "List file descriptors",
	"dd", " <file>", "Open and map that file into the UI",

	case ' ': // "dmi "
	case '': // "dmi"
	case 'v': // "dmiv"
	case 'j': // "dmij"
	case 'q': // "dmiq"
	case 'a': // "dmia"
	{
	const char libname = NULL, symname = NULL, *a0;

Convert d commands to rzshell #2263

Convert d commands to rzshell #2263

Conversation

imbillow commented Jan 28, 2022 • edited by XVilka Loading

ret2libc left a comment

Choose a reason for hiding this comment

ret2libc Mar 14, 2022

Choose a reason for hiding this comment

imbillow Mar 14, 2022

Choose a reason for hiding this comment

ret2libc Mar 14, 2022

Choose a reason for hiding this comment

imbillow Mar 14, 2022

Choose a reason for hiding this comment

imbillow Mar 14, 2022

Choose a reason for hiding this comment

ret2libc left a comment

Choose a reason for hiding this comment

imbillow commented Mar 16, 2022 • edited Loading

XVilka commented May 9, 2022

imbillow commented May 9, 2022

Convert `d` commands to rzshell #2263

Convert `d` commands to rzshell #2263

imbillow commented Jan 28, 2022 •

edited by XVilka

Loading

imbillow commented Mar 16, 2022 •

edited

Loading