Support building HTML output #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
force-pushed
the
user/timh/html
branch
from
a816cfe
to
0c3b6e0
Compare
andresag01
reviewed
Jan 23, 2024
Makefile
Outdated
| # Docker command | ||
| DOCKER = docker run --rm -v $(PWD):/build -w /build $(DOCKER_IMAGE) | ||
| # Docker command. `-it` is necessary so that ctrl-c works. | ||
| DOCKER = docker run -it --rm -v $(PWD):/build -w /build $(DOCKER_IMAGE) |
There was a problem hiding this comment.
I think -it stands for "interactive", which is probably why the CI is failing. Could you please take a look?
|
@Timmmm : Thanks for the changes to the Makefile. Looks good to me, but could you take a look at the failing CI? |
Timmmm
force-pushed
the
user/timh/html
branch
from
0c3b6e0
to
7038c5f
Compare
Add support for building the HTML version of the specification. By default `make` will still only build the PDF version; `make pdf` or `make html` will build one or the other, and `make all` will build both. `make all` is run in CI. I also deduplicated the asciidoc commands a bit, and fixed ctrl-c for the docker builds. See riscv#8
Timmmm
force-pushed
the
user/timh/html
branch
from
7038c5f
to
44e0af1
Compare
|
@Timmmm : Thanks for the change! The CI now passes, so I will merge it. |
arichardson
pushed a commit
to arichardson/riscv-cheri
that referenced
this pull request
Jan 30, 2024
Update the build process to use containers and add minor improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for building the HTML version of the specification. By default
makewill still only build the PDF version;make pdformake htmlwill build one or the other, andmake allwill build both.make allis run in CI.I also deduplicated the asciidoc commands a bit, and fixed ctrl-c for the docker builds.
See #8