Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bare metal toolchains #344

Closed
wants to merge 2 commits into from

Conversation

yogo1212
Copy link
Contributor

This addresses the issues that

  • ld.bfd doesn't support --exclude-libs
  • and there exists no dynsym section
    with riscv64-elf-.

Fixes #343.

With a bare-metal linkers (e.g. riscv64-elf-ld), there exists no dynsym section.
The dynsym section is not used by OpenSBI, so just discard it if it exists.
While writing to the dynsym is futile, the --exclude-libs options is not recognized by all linkers (e.g. riscv64-elf-ld.bfd)
@yogo1212
Copy link
Contributor Author

don't know what i did there just now.
hunk was missing from commit, make saw the changed file, git didn't - fixed now.

@avpatel
Copy link
Collaborator

avpatel commented Jan 26, 2024

We have mailing list based patch review so it would be great if you can send these patchs to OpenSBI mailing list.

You need to join OpenSBI mailing list using following link
http://lists.infradead.org/mailman/listinfo/opensbi

Make sure you use "git send-email" to send the patches.

Regards,
Anup

@egeKeyvan
Copy link

These changes also fixed the same problem that I had on MacOS Ventura. Is it possible for this patch to be merged ?

@yogo1212
Copy link
Contributor Author

@egeKeyvan the check for the option was merged.
are you talking about the dynsym removal?

@egeKeyvan
Copy link

@egeKeyvan the check for the option was merged.
are you talking about the dynsym removal?

I was talking about the dynsym removal. Without it, I had the problems of the #343

@avpatel
Copy link
Collaborator

avpatel commented Aug 29, 2024

Most of these changes are already in latest OpenSBI. Please send patches to mailing list for any unaddressed issues.

@avpatel avpatel closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ld.bfd: unrecognized option --exclude-libs
3 participants