Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation docs need to specify correct version of GTDB to download (max R214) #205

Open
smdabdoub opened this issue May 13, 2024 · 5 comments

Comments

@smdabdoub
Copy link

Since Aviary installs GTDB-tk v2.3.2, users can download, at most, GTDB R214.

GTDB-tk v2.4.0 switches from fastani to skani which changes paths in the database causing the GTDB task in Aviary to fail with the following message:

ERROR: Reference genome missing from FastANI database: release220/fastani/database/GCF...

@smdabdoub
Copy link
Author

Manually updating the internal GTDB-tk conda environment to v2.4.0 does not appear to cause any issues.

@julianzaugg
Copy link
Contributor

@rhysnewell Just adding to this: GTDB R220 has now been released, so the documentation (and corresponding GTDB-Tk version 2.4.0) should be updated to reflect this.

@wwood
Copy link
Collaborator

wwood commented May 22, 2024

Relatedly, the path here:

'DB_URL="https://data.gtdb.ecogenomic.org/releases/latest/auxillary_files/gtdbtk_data.tar.gz"; '

'DB_URL="https://data.gtdb.ecogenomic.org/releases/latest/auxillary_files/gtdbtk_data.tar.gz"; '

is now wrong, I guess should be https://data.gtdb.ecogenomic.org/releases/latest/auxillary_files/gtdbtk_package/full_package/gtdbtk_data.tar.gz

but it should also be pinned to the GTDBtk version being used. There are also some places in the documentation that still refer to r207. We should take a more comprehensive approach as updates will come in the future too.

JamesRH added a commit to JamesRH/aviary that referenced this issue Jun 2, 2024
JamesRH added a commit to JamesRH/aviary that referenced this issue Jun 2, 2024
@Anna-MarieSeelen
Copy link

Anna-MarieSeelen commented Nov 21, 2024

Hi I got the same error as @smdabdoub, and manually updated gtdb-tk in the conda environment used for the gtdb-tk rule using conda update gtdbtk. However I still got the same error, because aviary still thinks its using GTDB-tk v2.3.2 for some reason --> see attached log file. Is there something else I need to change for aviary to work with release220 of the GTDB?

Aviary_5436167_stderr.txt
gtdbtk.log

@Anna-MarieSeelen
Copy link

Actually I ran aviary recover again to double check and now the correct version of GTDB-tk, namely 2.4.0. is correctly stated in log file and the GTDB-tk step is thus running for me without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants