Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure if the calculation works right... #8

Open
Ovicula opened this issue Mar 31, 2016 · 4 comments
Open

Not sure if the calculation works right... #8

Ovicula opened this issue Mar 31, 2016 · 4 comments

Comments

@Ovicula
Copy link
Collaborator

Ovicula commented Mar 31, 2016

The program works now except for the plot and the saving of data in a csv-file (which will be the last thing I'll do..).
But: The results are quite strange....The printed Kd- value is really high and I'm not sure why? Could you maybe check if you can find the mistake? Maybe there is some problem of assigning the right corresponding values to each other?
Thanks!

@rgiessmann
Copy link
Owner

@Ovicula, did you recheck the results with the old fitting method (with R)
? Please do that, and check how the calculated correction factors look like in a
graphical way (with PeakScanner). Let's see where the problem comes from (I
will continue in the evening)!

On Thu, Mar 31, 2016 at 11:51 AM, Ovicula [email protected] wrote:

The program works now except for the plot and the saving of data in a
csv-file (which will be the last thing I'll do..).
But: The results are quite strange....The printed Kd- value is really high
and I'm not sure why? Could you maybe check if you can find the mistake?
Maybe there is some problem of assigning the right corresponding values to
each other?
Thanks!


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#8

@Ovicula
Copy link
Collaborator Author

Ovicula commented Mar 31, 2016

I looked at the traces in PeakScanner and it seems like there were some problems with sample 8, 15 and maybe 16, so we should probably delete them from the sample lists. But still there is something weird. I'm not sure what the problems is but I will keep searching.
Where can I find the R script?

Maybe we could skype tomorrow in the afternoon?

@Ovicula
Copy link
Collaborator Author

Ovicula commented Mar 31, 2016

@rgiessmann
prog.pdf
I don't know how to comment in here, so I just commented in a pdf. The program is a little bit different in there because I updated it afterwards but it still shows what I want to say.
My comments might be a little bit unorganized because I just wrote down my thoughts but I think it could help to find the problems.
We probably don't have to skype tomorrow but if you could leave your comments somewhere it would be great :)

@rgiessmann
Copy link
Owner

Hei @Ovicula , I checked the source code and for some pieces I'm pretty sure they do not work as you want them to work.

Please construct -- or use -- test cases similar to the one I provided, and go through all the functions step by step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants