Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(it-just-works): show loading indicator and failure error message in sample wallet #373

Open
arein opened this issue Dec 29, 2023 · 1 comment
Assignees

Comments

@arein
Copy link
Contributor

arein commented Dec 29, 2023

Currently after typing in a wc2 URI and clicking connect there is no loading indicator. In web3modal UI tests you can see that often nothing happens without an error message. This blocks parallelizing and improving quality of the web3modal tests.

Expected behavior:

  1. visible loading indicator
  2. timeout with good error message if the session approve model doesn't pop open within X seconds
@bkrem
Copy link
Member

bkrem commented Feb 12, 2024

@ganchoradkov I think we can close this? There's an ellipsis loading indicator on the Connect button now from what I can see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants