Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Fade in/out on play/pause #15

Open
LoScienzo opened this issue Jan 11, 2024 · 3 comments
Open

[Feature Request] Fade in/out on play/pause #15

LoScienzo opened this issue Jan 11, 2024 · 3 comments

Comments

@LoScienzo
Copy link

I'd fade the mix in or out when pressing play or pause:
right now the start and stop is immediate, which feels a bit abrupt for the calming vibe.

Thank you for this nifty piece of software! I also love the UI look and the ability to run it locally

@remvze
Copy link
Owner

remvze commented Feb 11, 2024

Hey there! I tried implementing this feature twice (5467bbb, 663cb92) and failed both times (d96461d, 653d309) due to the fading effect causing bugs in specific scenarios.

@SuperMeepBoy
Copy link
Contributor

SuperMeepBoy commented Apr 24, 2024

@remvze Any chance you remember what were the specific scenarios and the bugs ? :)

@remvze
Copy link
Owner

remvze commented Apr 24, 2024

@remvze Any chance you remember what were the specific scenarios and the bugs ? :)

If I remember correctly, it would make sounds unstable in a way that when you switched sounds or turned them on and off too quickly, it would crash and the sounds wouldn't play correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants