Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pnpm #3

Open
glenn-vandeputte opened this issue Nov 28, 2024 · 4 comments
Open

Support for pnpm #3

glenn-vandeputte opened this issue Nov 28, 2024 · 4 comments

Comments

@glenn-vandeputte
Copy link

I wanted to add release-it to a repo which uses pnpm instead of npm, but it fails because at the end of the script it is hardcoded to do npm install --save-dev release-it.

Could this be made configurable so it could be pnpm add --save-dev? Or auto detect it the same way the github or gitlab remote repo is detected? I'm happy to make a PR if I get some indication wether this is something which you want implemented.

@webpro
Copy link
Collaborator

webpro commented Nov 28, 2024

Only now I see there's also #2 🙈 If I merge that, is that something we could work with?

@webpro
Copy link
Collaborator

webpro commented Nov 28, 2024

Feel free to take your own stab at it btw, happy to receive PR(s)

@glenn-vandeputte
Copy link
Author

Ok I completely missed that PR 🙈 . I guess that would work indeed.

@webpro
Copy link
Collaborator

webpro commented Nov 29, 2024

Just tried the PR, doesn't work, perhaps we can use e.g. https://github.com/antfu-collective/package-manager-detector for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants