Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Compatibility Check Error Message with the wrong link (Page Not Found error) #8224

Closed
1 task done
ahaywood opened this issue May 4, 2023 · 9 comments · Fixed by #8226
Closed
1 task done
Labels
bug/needs-info More information is needed for reproduction

Comments

@ahaywood
Copy link
Contributor

ahaywood commented May 4, 2023

What's not working?

If there's a compatibility issue when installing Redwood, the link in the error message goes to the wrong place.

How do we reproduce the bug?

I ran yarn create redwood-app my-successful-app

I ran into a compatibility issue:
CleanShot 2023-05-04 at 15 31 43@2x

When I click on the link, it takes me here: https://redwoodjs.com/docs/tutorial/chapter1/prerequisites%E2%80%8B
CleanShot 2023-05-04 at 15 33 43@2x

which does not exist.

It looks like the printed link is correct, but somehow I zero-width space character %E2%80%8B is tacked on and encoded at the end of the URL.

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@ahaywood ahaywood added the bug/needs-info More information is needed for reproduction label May 4, 2023
@ahaywood ahaywood changed the title [Bug?]: [Bug]: Compatibility Check Error Message with the wrong link (Page Not Found error) May 4, 2023
@thedavidprice
Copy link
Contributor

Gah! This explains the massive amount of errors we're getting right now. I vaguely recall running across something like this in the past — it's possible there's something busted between the yarn version reported in the console output and the yarn version (different bin path) that's used for the semver check.

Here's where the semver check code lives:
https://github.com/redwoodjs/redwood/blob/8913c0558865c30642de92415647c8c93a072307/packages/create-redwood-app/src/create-redwood-app.js#L75C32-L78

Any chance you have time today to help diagnose?

cc @Josh-Walker-GM

@thedavidprice
Copy link
Contributor

Oh, one more thing you can do to help @ahaywood From the parent directory you are attempting to install into (probably /Users/amydutton/Dropbox/1 - PROJECTS/ENDLESS-IDEAS-MACHINE/CODE/) can you check the yarn version and report back?

I feel like this could also be the case where you've installed Yarn 3 globally and our semver check gets messed up.

PS: don't you know that it's a part of developer lore to never put your repos inside Dropbox cause sync fights with git?? 😉

@ahaywood
Copy link
Contributor Author

ahaywood commented May 4, 2023

😂 Guilty and caught red-handed. I keep thinking, "I'm invincible. Dropbox likes me. It won't give me trouble."

CleanShot 2023-05-04 at 16 19 18@2x

@ahaywood
Copy link
Contributor Author

ahaywood commented May 4, 2023

Update: Worked with @jtoar

The error message being reported by yarn create redwood-app is wrong: it should be saying “node is too low,” but it says “yarn is too low/high” which isn’t true

If I set Node to v18 and try again it works like a champ.

@jtoar
Copy link
Contributor

jtoar commented May 4, 2023

I can't reproduce the link being wrong yet in my terminal; here it is in the source:

'https://redwoodjs.com/docs/tutorial/chapter1/prerequisites'

If you copy paste that it's right, so maybe something is going wrong with terminalLink rendering that's specific to your terminal—mind sharing which terminal emulator you're using locally so I could try reproducing?

@jtoar
Copy link
Contributor

jtoar commented May 4, 2023

Reopening till we get the link sorted out

@jtoar jtoar reopened this May 4, 2023
@ahaywood
Copy link
Contributor Author

ahaywood commented May 5, 2023

I'm using Hyper
CleanShot 2023-05-04 at 19 23 43@2x

@Josh-Walker-GM
Copy link
Collaborator

Sounds similar to sindresorhus/terminal-link#18

@jtoar
Copy link
Contributor

jtoar commented May 5, 2023

I can reproduce this in hyper, thanks @ahaywood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/needs-info More information is needed for reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants