Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): optionally allow custom logger to be provided #1851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iainsproat
Copy link

@iainsproat iainsproat commented Jan 23, 2024

In many environments logging to console is not recommended, and instead a different logging mechanism is used. This may be to provide metadata, or to ensure the logged message conforms to a particular format (e.g. json), etc..

This Pull Request allows a different logging mechanism to optionally be provided. The logging mechanism must conform to the existing interface expected of console; e.g. it must provide an error, warn, and log method.

Defaults to console, which is the existing behaviour.

@rajithavk
Copy link

Why isn't this merged yet?

@Necrelox
Copy link

Exactly what was missing in ioredis, the ability to have a custom logger.

Please, I hope you can merge this quickly, it's been several months already 😅

It's exactly what I need right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants