tuned-ppd: Support the new UPower PPD namespace #684
Conversation
Since version 0.20, power-profiles-daemon exposes its DBus interface under "org.freedesktop.UPower.PowerProfiles" alongside the previous name. To be compatible with PPD, this commit implements the same change into tuned-ppd. Resolves: redhat-performance#683
|
Please be careful with this, the PPD namespace has other changes that are in flight. |
|
Thanks for the heads up, @superm1. I just had a look at the proposed power-profiles-daemon changes, but I don't see anything that should be an immediate problem for us. IIUC, you're adding some new functionality to the existing PPD namespace. As of now, tuned-ppd does not aim to cover the entire functionality - we're mostly interested in what's actively used by power management daemons such as powerdevil or gnome-control-center. The new functionality may or may not be added in the future. |
Yeah I mostly worry about both software suites using the same name and interface but then downstream software making assumptions on that. Just want to avoid stepping on egg shells in the API design where possible. Maybe it's best to advertise a compatibility level as well? I recall PPD has a version property. Maybe you can use "0.23" to indicate you match the API from 0.23 release? |
Thanks, that's a nice suggestion, I added it into another open PR. |
|
Can we please get this landed? Final Freeze is on Tuesday, and this needs to be in before then as things are listening on the UPower namespace exclusively already. |
Thanks for the info, @zacikpa will backport it to Fedora today to land in Fedora on time. |
|
Thanks! |
|
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ceee3c1021 it seems stuck in testing. |
Since version 0.20, power-profiles-daemon exposes
its DBus interface under "org.freedesktop.UPower.PowerProfiles" alongside the previous name. To be compatible with PPD, this commit implements the same change into tuned-ppd.
Resolves: #683