Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not go back in .class files when preview mode enabled #3825

Open
mamilic opened this issue Oct 22, 2024 · 1 comment
Open

Can not go back in .class files when preview mode enabled #3825

mamilic opened this issue Oct 22, 2024 · 1 comment

Comments

@mamilic
Copy link

mamilic commented Oct 22, 2024

With Enable Preview From Code Navigation turned on, navigating through multiple dependecy files will not get me get back in the same order.

Environment
  • Operating System: WIndows 11
  • JDK version: 21
  • Visual Studio Code version: 1.94.2
  • Java extension version: 1.35.1
Steps To Reproduce
  1. Clone demo.zip
  2. Enable Enable Preview From Code Navigation in VsCode settings
  3. Open DemoApplication.java
  4. Navigate to SpringApplication by CTRL+Left Click, and then navigate to SpringApplicationBannerPrinter, it will open the claas in the same tab
  5. Try to navigate back, it will get you back to the DemoApplication instead of SpringApplication, it will completly ignore dependency claas

The outcome should be that the navigation should go through all visited places in editor, including .claas files opened in same tab.

@rgrunber rgrunber changed the title Can not go back in .claas files when navigating Can not go back in .class files when navigating Oct 25, 2024
@rgrunber
Copy link
Member

I see the same behaviour. I'm not sure if we have any control over this though. It almost seems like VS Code itself doesn't properly store the navigation history when preview mode is enabled for workbench editors. microsoft/vscode#166194 would seem to imply that's the case.

Definitely a bug, but unless I'm missing something we can do to fix this, I think this should be filed upstream in VS Code. CC'ing @testforstephen in case he might know.

@rgrunber rgrunber changed the title Can not go back in .class files when navigating Can not go back in .class files when preview mode enabled Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants