Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create replica-1 sc for external mode if topology details are provided #2501

Merged

Conversation

malayparida2000
Copy link
Contributor

In external mode if replica-1 is enabled & topology details are provided then create a storage class for replica-1. We construct the TopologyConstrainedPools from the topology details provided in the external cluster details secret.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@malayparida2000
Copy link
Contributor Author

Depends on-rook/rook#13821

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@parth-gr: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@malayparida2000 malayparida2000 changed the title [wip] Create replica-1 sc for external mode if topology details are provided Create replica-1 sc for external mode if topology details are provided Mar 12, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@malayparida2000
Copy link
Contributor Author

malayparida2000 commented Mar 15, 2024

Tested the generated topologyConstarinedPools format from the json given by Parth from the rook PR. It looks good.

[
  {
    "poolName": "replica1a",
    "domainSegments": [
      {
        "domainLabel": "hostname",
        "value": "minikube"
      }
    ]
  },
  {
    "poolName": "replica1b",
    "domainSegments": [
      {
        "domainLabel": "hostname",
        "value": "minikube-m02"
      }
    ]
  },
  {
    "poolName": "replica1c",
    "domainSegments": [
      {
        "domainLabel": "hostname",
        "value": "minikube-m03"
      }
    ]
  }
]

In external mode if topology details are provided then create a
storageClass for replica-1. We construct the TopologyConstrainedPools
from the topology details provided in the external cluster secret.

Signed-off-by: Malay Kumar Parida <[email protected]>
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for rook PR to get merged.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 15, 2024
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@malayparida2000
Copy link
Contributor Author

/test ocs-operator-bundle-e2e-aws

@malayparida2000
Copy link
Contributor Author

malayparida2000 commented Mar 19, 2024

Removing hold as rook PR has merged

@malayparida2000
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c20c487 into red-hat-storage:main Mar 19, 2024
11 checks passed
@malayparida2000 malayparida2000 deleted the replica_1_external branch June 11, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants