-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create replica-1 sc for external mode if topology details are provided #2501
Create replica-1 sc for external mode if topology details are provided #2501
Conversation
Depends on-rook/rook#13821 |
@parth-gr: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0566258
to
ea52338
Compare
Tested the generated topologyConstarinedPools format from the json given by Parth from the rook PR. It looks good.
|
In external mode if topology details are provided then create a storageClass for replica-1. We construct the TopologyConstrainedPools from the topology details provided in the external cluster secret. Signed-off-by: Malay Kumar Parida <[email protected]>
ea52338
to
64e288d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold for rook PR to get merged.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ocs-operator-bundle-e2e-aws |
Removing hold as rook PR has merged |
/hold cancel |
c20c487
into
red-hat-storage:main
In external mode if replica-1 is enabled & topology details are provided then create a storage class for replica-1. We construct the TopologyConstrainedPools from the topology details provided in the external cluster details secret.